add e2e test for top-level await in middleware #705
Conversation
|
| const topLevelAwait = await new Promise<string>((resolve) => { | ||
| setTimeout(() => { | ||
| resolve("top-level-await"); | ||
| }, 150); |
There was a problem hiding this comment.
Interesting - does it have to have a timeout? Would await Promise.resolve('top-level-await') work w/o the timeout?
There was a problem hiding this comment.
Not necessarily, it should work with Promise.resolve. I just wanted to emulate some wait time and be sure that we are not running on the same loop of the event loop.
We can probably make it 5 or 10 ms, no need for 150
2 participants
This PR add test for #704
I've added a
@ts-expect-errorfor the top level await, i didn't want to go down the rabbit hole of finding the issue here (middleware is somehow considered a cjs file and if set as a module,next/serverimport does not work anymore)There is also a build time warning, but it still works both with
next startor in the e2e test